Skip to content

Add Tait-Bryan convention and quaternion formula to documentation #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

Add Tait-Bryan convention and quaternion formula to documentation #850

merged 2 commits into from
Jul 11, 2025

Conversation

thomassedlmayer
Copy link
Contributor

This PR adds the specification of the exact Tait-Bryan axis rotation sequence convention that is used in OSI.
It also adds a formula to convert yaw, pitch, roll orientation to quaternions.

image

Apparently, the bibliography is not located in this repository, so the two additional citations still have to be somehow added to the bibliography:

@thomassedlmayer thomassedlmayer added the Documentation Everything which impacts the quality of the documentation and guidelines. label Jan 28, 2025
@thomassedlmayer thomassedlmayer added this to the V3.8.0 milestone Jan 28, 2025
@thomassedlmayer
Copy link
Contributor Author

Note that this still has to be tackled:

Apparently, the bibliography is not located in this repository, so the two additional citations still have to be somehow added to the bibliography:
tait_bryan_convention: https://en.wikipedia.org/wiki/Euler_angles#Conventions
euler_to_quaternion: https://en.wikipedia.org/wiki/Rotation_formalisms_in_three_dimensions#Euler_angles_(z-y%E2%80%B2-x%E2%80%B3_intrinsic)_%E2%86%92_quaternion

I did not yet find out how to add entries to the bibliography.

@thomassedlmayer thomassedlmayer mentioned this pull request Feb 26, 2025
Open
@yash-shah-asam yash-shah-asam modified the milestones: V3.8.0, V3.7.1 Apr 10, 2025
@yash-shah-asam yash-shah-asam requested a review from pmai April 10, 2025 08:12
@yash-shah-asam
Copy link
Member

ASAM OSI CCB 2025-04-10: Need to check where the bibliography can be placed before merging to v3.7.1.

@yash-shah-asam yash-shah-asam requested a review from atingber April 10, 2025 08:14
@pmai pmai self-assigned this Apr 10, 2025
@jdsika jdsika mentioned this pull request May 7, 2025
Open
4 tasks
@thomassedlmayer thomassedlmayer mentioned this pull request Jul 7, 2025
Merged
@thomassedlmayer
Copy link
Contributor Author

I created a PR to add the references to the bibliography in osi-documentation: OpenSimulationInterface/osi-documentation#82

@thomassedlmayer thomassedlmayer added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Jul 7, 2025
@AsamDiegoSanchez
Copy link

CCB 2025-07-11: Decision: All agreed to merge it.

@pmai pmai force-pushed the docs/rotation-quat branch from a8fb764 to b993800 Compare July 11, 2025 08:41
@pmai pmai merged commit 49a0ceb into OpenSimulationInterface:master Jul 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmai pmai pmai approved these changes

@jdsika jdsika jdsika approved these changes

@atingber atingber Awaiting requested review from atingber

Assignees

@pmai pmai

Labels
Documentation Everything which impacts the quality of the documentation and guidelines. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB.
Projects
None yet
Milestone
V3.7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@thomassedlmayer @yash-shah-asam @AsamDiegoSanchez @pmai @jdsika